[Project Solar / Phase 1 / Components] Card carbonization#3679
Open
dchyun wants to merge 5 commits intoproject-solar/phase-1-main-feature-branchfrom
Open
[Project Solar / Phase 1 / Components] Card carbonization#3679dchyun wants to merge 5 commits intoproject-solar/phase-1-main-feature-branchfrom
Card carbonization#3679dchyun wants to merge 5 commits intoproject-solar/phase-1-main-feature-branchfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
45 tasks
Contributor
|
@dchyun I added a few responses in questions doc, I'm open to other opinions but what I've done:
|
didoo
force-pushed
the
project-solar/phase-1-main-feature-branch
branch
from
5a0c760 to
e808c1b
Compare
didoo
force-pushed
the
project-solar/phase-1/dchyun/card-carbonization
branch
from
3178760 to
f53ec05
Compare
didoo
force-pushed
the
project-solar/phase-1/dchyun/card-carbonization
branch
from
f53ec05 to
13cc7fa
Compare
didoo
force-pushed
the
project-solar/phase-1/dchyun/card-carbonization
branch
from
13cc7fa to
2b32ecf
Compare
didoo
force-pushed
the
project-solar/phase-1-main-feature-branch
branch
2 times, most recently
from
bd6bcdf to
395ea90
Compare
hashibot-hds
added
packages/flight-icons
docs-website
didoo
force-pushed
the
project-solar/phase-1-main-feature-branch
branch
from
395ea90 to
6d0c7de
Compare
didoo
force-pushed
the
project-solar/phase-1/dchyun/card-carbonization
branch
from
4f3e8c5 to
9e14628
Compare
hashibot-hds
removed
packages/flight-icons
docs-website
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR carbonizes the
CardContainercomponent and adds component tokens for it to the tokens library.Card carbonization page
🛠️ Detailed description
Summary of changes
🔗 External links
Jira ticket: HDS-6078
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.